xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Caprioara (Jira)" <j...@apache.org>
Subject [jira] [Commented] (FOP-2960) [PATCH] Soft-Hyphen on Hyphenated words.
Date Mon, 26 Jul 2021 08:12:00 GMT

    [ https://issues.apache.org/jira/browse/FOP-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17387155#comment-17387155
] 

Dan Caprioara commented on FOP-2960:
------------------------------------

There might be problems with this patch.

Having the following text, with hyphens auto, and a small size for the container:
{code}
super&#xAD;califragil&#xAD;isticexpiali&#xAD;dolcius.supercalifragilisticexpialidolcius
{code}
The result is:

{code}

supercalifragilisticexpiali-
dolcius.supercalifragilisticexpialidolcius

{code}

Note that the second {{supercalifragilisticexpialidolcius}} is bleeding to the right side
of the page and is not segmented anymore. Since the hyphenation is on "auto", not "manual",
I expect the breaking algorithm to take into account both normal hyphenation points and the
ones indicated by the soft hyphens.

> [PATCH] Soft-Hyphen on Hyphenated words.
> ----------------------------------------
>
>                 Key: FOP-2960
>                 URL: https://issues.apache.org/jira/browse/FOP-2960
>             Project: FOP
>          Issue Type: Bug
>          Components: layout/line
>    Affects Versions: 1.1
>            Reporter: Juan
>            Assignee: Chris Bowditch
>            Priority: Minor
>              Labels: hyphenation, soft-hyphen
>             Fix For: 2.6
>
>         Attachments: fix-soft-hyphens-on-hyphenated-words.patch
>
>
> When hyphenate="true", a word containing a soft-hyphen ( ­\u00ad ) will break line at
the position given by the higher level word hyphenation, ignoring the pre-hyphenation made
by applying soft-hyphens.
>  
> About the patch:
> Fixes the disabled test "block_shy_linebreaking_hyph.xml" wich is related to FOP-2466
by disabling the higher level hyphenation when a word contains a soft-hyphen.
> Note that at this part of the code, the original word has been already divided into 2
words by the soft-hyphen, to workaround this, we look at current and previous Glyphs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message