xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Bowditch (Jira)" <j...@apache.org>
Subject [jira] [Commented] (FOP-2985) [PATCH] SVG Images inherit font configuration from sibling objects.
Date Wed, 23 Dec 2020 11:55:00 GMT

    [ https://issues.apache.org/jira/browse/FOP-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254050#comment-17254050
] 

Chris Bowditch commented on FOP-2985:
-------------------------------------

I don't think this is the right solution. As you mention its specific fix to PDF, and I don't
think we should be calling beginText when rendering an image. We don't even know if the image
is an SVG at the place where you inserted this code. I think letter spacing should be reset
when ending the fo:inline with it set, and this should be done in AbstractRenderer or IFRenderer
not in PDFPainter

> [PATCH] SVG Images inherit font configuration from sibling objects.
> -------------------------------------------------------------------
>
>                 Key: FOP-2985
>                 URL: https://issues.apache.org/jira/browse/FOP-2985
>             Project: FOP
>          Issue Type: Bug
>          Components: image/svg
>            Reporter: Juan
>            Priority: Minor
>         Attachments: SVG-letter-spacing.patch, input.fo, sample.svg
>
>
> Given the sample [^input.fo] (adjust the path to sample.svg), the letter spacing of
an inline element in a previous block is being applied also to an external-graphic element
on a different block.
> The letter spacing property in the inline element should not affect the external-graphic
in a different block.
> Additionally, setting letter-spacing on the external-graphic or it's parent block has
no effect and the content still used the letter-spacing of the previous inline text.
>  
> The given patch [^SVG-letter-spacing.patch] does fix the issue with letter-spacing,
altough *it might need a more generic approach*.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message