xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias Pigulla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FOP-2704) [PATCH] Google fonts Roboto font (updated 2017) UnsupportedOperationException: coverage set class table not yet supported
Date Fri, 12 Jul 2019 13:54:00 GMT

    [ https://issues.apache.org/jira/browse/FOP-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883830#comment-16883830
] 

Matthias Pigulla commented on FOP-2704:
---------------------------------------

I have applied the patch suggested by Neil to the FOP 2.3 release branch – it _works for
me_™️.

If you want to give it a try, you can see the changes at https://github.com/webfactory/fop/pull/1.
Also, at https://jitpack.io/#webfactory/fop/da392ffca you'll find instructions how to easily
try this change with your preferred build system.


> [PATCH] Google fonts Roboto font (updated 2017) UnsupportedOperationException: coverage
set class table not yet supported
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FOP-2704
>                 URL: https://issues.apache.org/jira/browse/FOP-2704
>             Project: FOP
>          Issue Type: Bug
>          Components: font/opentype
>    Affects Versions: 2.1, 2.2
>            Reporter: Dan Caprioara
>            Priority: Major
>         Attachments: Roboto-Regular.ttf, Roboto-Thin.ttf, font-workaround.patch
>
>
> Steps:
> # Download the Roboto TTF font from Google Fonts. 
> # Create a configuration file with a triplet pointing to the "roboto-regular" or "roboto-thin"
TTF file.
> You get:
> {code}
> java.lang.UnsupportedOperationException: coverage set class table not yet supported
> 	at org.apache.fop.complexscripts.fonts.GlyphClassTable$CoverageSetClassTable.<init>(GlyphClassTable.java:262)
> 	at org.apache.fop.complexscripts.fonts.GlyphClassTable.createClassTable(GlyphClassTable.java:88)
> 	at org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEFMarkGlyphsTableFormat1(OTFAdvancedTypographicTableReader_Original.java:3344)
> 	at org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader.readGDEFMarkGlyphsTableFormat1(OTFAdvancedTypographicTableReader.java:69)
> 	at org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEFMarkGlyphsTable(OTFAdvancedTypographicTableReader_Original.java:3357)
> 	at org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readGDEF(OTFAdvancedTypographicTableReader_Original.java:3427)
> 	at org.apache.fop.complexscripts.fonts.OTFAdvancedTypographicTableReader_Original.readAll(OTFAdvancedTypographicTableReader_Original.java:80)
> 	at org.apache.fop.fonts.truetype.OpenFont.handleCharacterSpacing(OpenFont.java:786)
> 	at org.apache.fop.fonts.truetype.OpenFont.readFont(OpenFont.java:755)
> 	at org.apache.fop.fonts.truetype.OFFontLoader.read(OFFontLoader.java:109)
> 	at org.apache.fop.fonts.truetype.OFFontLoader.read(OFFontLoader.java:93)
> {code}
> There are two changes that should be done to the {{OTFAdvancedTypographicTableReader}}.
> # The method {{readGDEFMarkGlyphsTableFormat1}} should catch this exception
> # The method {{constructLookupsLanguage}} should check if the {{languages}} parameter
is null.
> After these changes, the PDF is produced and it looks good. I am not sure what are the
side effects on the font that is embedded into the PDF..



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Mime
View raw message