xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "simon steiner (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (FOP-2784) [PATCH] FOP-2738: correct array offset when string span interator is used
Date Thu, 10 May 2018 08:33:00 GMT

    [ https://issues.apache.org/jira/browse/FOP-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470068#comment-16470068

simon steiner edited comment on FOP-2784 at 5/10/18 8:32 AM:

The unit tests are failing for this change, do they need updating/ check no regression is

was (Author: ssteiner1):
Can you add a unit test?

> [PATCH] FOP-2738: correct array offset when string span interator is used
> -------------------------------------------------------------------------
>                 Key: FOP-2784
>                 URL: https://issues.apache.org/jira/browse/FOP-2784
>             Project: FOP
>          Issue Type: Improvement
>          Components: font/unqualified
>    Affects Versions: 2.2
>            Reporter: Vlad Ivanov
>            Priority: Major
>         Attachments: 0001-FOP-2738-correct-array-offset-when-string-span-inter.patch,
fop.conf, fop1.fo, image.svg
> This patch fixes FOP-2738.
> The issue occurred when code in GlyphMapping.java was used with string span iterator.
This kind of iterator points somewhere in the string, not necessarily the start; however,
iterator indexes were used to index into an array, which caused an exception in some cases.
Fix removes iterator index offset in addLetterAdjust.
> Reproducing:
> {code}
> fop -c fop.conf fop1.fo fop1.pdf
> {code}

This message was sent by Atlassian JIRA

View raw message