xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Bowditch (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FOP-2601) [PATCH] Cannot resolve fonts from custom URI schemes
Date Mon, 18 Apr 2016 08:08:25 GMT

    [ https://issues.apache.org/jira/browse/FOP-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245279#comment-15245279
] 

Chris Bowditch commented on FOP-2601:
-------------------------------------

Hi Adam, thanks for submitting the patch. I don't like the fact that you've changed the ResourceResolver
and TempResourceResolver interfaces. Don't forget that this is used by every user implementation
that embeds FOP in their own application. I wonder if there is a way to support custom URI
schemes without the need to expose getLastModified Date from these interfaces? Thanks

> [PATCH] Cannot resolve fonts from custom URI schemes
> ----------------------------------------------------
>
>                 Key: FOP-2601
>                 URL: https://issues.apache.org/jira/browse/FOP-2601
>             Project: FOP
>          Issue Type: Bug
>    Affects Versions: 2.1
>            Reporter: adam Retter
>         Attachments: fop-last-modified-resolution.patch, xmlgraphics-commons-last-modified-resolution.patch
>
>
> I attach two patches (one for xmlgraphics-commons and one for fop) that allow fonts to
be resolved from custom URI schemes. Previously this only worked if you disabled font caching,
because the font cache tries to get the last modified date using java.io.File, which will
fail for fonts that are resolved from locations other than the filesystem. The fix is relatively
trivial, basically the UriResolver needs to also be able to resolve the last modified date
of the resource or return -1 if it is not possible.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message