xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexios Giotis <alex.gio...@gmail.com>
Subject Re: [jira] [Closed] (FOP-1840) [PATCH] Region-Body Column balancing incorrect if content is table with header
Date Fri, 14 Dec 2012 16:44:19 GMT
Hi Pascal,

I noticed the "Fix Version/s" Jira field and I was tempted to update it while resolving the
issue. But the only version that applies is "trunk" which is a moving target...

I have not seen any guidelines related to Jira and FOP. If I miss something, please do tell
me. I think, one should first decide the version number of the trunk (1.2 ? 2.0 ?) and add
it to Jira. If an issue requires changes in code, then committers need to resolve it and update
the "Fix" version. Finally, Jira creates "Release notes" based on this information and one
should consider if and how this affects the usage of the status.xml

Alexis





On 14 Dec 2012, at 17:07, Pascal Sancho <psancho.asf@gmail.com> wrote:

> Hi,
> 
> before closing a bug, I think one should indicate what version its
> resolution does affect.
> 
> The goal is to easily manage changes pages in FOP website.
> 
> 2012/12/14 Alexis Giotis (JIRA) <jira@apache.org>:
>> 
>>     [ https://issues.apache.org/jira/browse/FOP-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
>> 
>> Alexis Giotis closed FOP-1840.
>> ------------------------------
>> 
>> 
>>> [PATCH] Region-Body Column balancing incorrect if content is table with header
>>> ------------------------------------------------------------------------------
>>> 
>>>                Key: FOP-1840
>>>                URL: https://issues.apache.org/jira/browse/FOP-1840
>>>            Project: Fop
>>>         Issue Type: Improvement
>>>         Components: page-master/layout
>>>   Affects Versions: 1.0
>>>        Environment: Operating System: All
>>> Platform: PC
>>>           Reporter: a.kovacs
>>>           Assignee: fop-dev
>>>        Attachments: b49801_dirty_hack.patch, b49801.fo, balance-2-expected.pdf,
balance-2.fo, balance-2.pdf, balance-3.fo.xml, balance-4-edited.fo.xml, balance-4.fo.xml,
balance-4-none.fo.xml, balance-4.pdf, balance-5.fo, balancing-fos.zip, fix.diff, fo.xml, output-balance5.pdf,
patch.diff, test-after.pdf, test-before.pdf
>>> 
>>> 
>>> To reproduce bug please do the following:
>>> Use:
>>> <fo:region-body region-name="PageBody" column-count="2" />
>>> Fill the region-body with content like :
>>> <fo:block span="none" > ...(content is table with header) ..
>>> <fo:block span="all"> ... (one line (summary)) ..
>>> If the content is made of normal blocks the columns are balanced before the span="all"
summary line.
>>> like:
>>> 123456    456789
>>> 234567    567890
>>> 345678    678901
>>> Summary: 1234567890
>>> If the content is a table without headers the columns are balanced correct.
>>> like:
>>> 123456    456789
>>> 234567    567890
>>> 345678    678901
>>> Summary: 1234567890
>>> If the content is a table with header the columns are not balanced correct. (the
right one is shorter.)
>>> Header    Header
>>> 123456    567890
>>> 234567    678901
>>> 345678
>>> 456789
>>> Summary: 1234567890
>>> The "computeDemerits()" algorithm is wrong in class "BalancingColumnBreakingAlgorithm".
>>> The "fullLen" value is to short. Exactly the replicated header width is missing.
In the "par" list the header is contained only once although the header is displayed in every
column. (in the example twice)
>>> Solution could be to place the header as many times in the "par" list as many
columns exist, or to count the existing one header as many times as needed.
>> 
>> --
>> This message is automatically generated by JIRA.
>> If you think it was sent incorrectly, please contact your JIRA administrators
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
> 
> 
> 
> -- 
> pascal


Mime
View raw message