xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Bowditch <bowditch_ch...@hotmail.com>
Subject Fwd: Re: svn commit: r1235191 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFontLoader.java
Date Tue, 24 Jan 2012 14:47:00 GMT
Hi Mehdi,

On 24/01/2012 10:02, mehdi@apache.org wrote:

>  Author: mehdi
>  Date: Tue Jan 24 10:02:36 2012
>  New Revision: 1235191
>
>  URL: http://svn.apache.org/viewvc?rev=1235191&view=rev
>  Log:
>  Corrected typo in error message

Well spotted. I think it's great that we now get an error instead of a
corrupt PDF in the case of license restricted Fonts, but the message
could be clearer, i.e. it does not say why the font is not embedable.
IMHO, the following would be clearer still:

String msg = "The license of font " + this.fontFileURI + " does not allow it to be embedded
in the output file.";


Thanks,

Chris

>
>  Modified:
>       xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFontLoader.java
>
>  Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFontLoader.java
>  URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFontLoader.java?rev=1235191&r1=1235190&r2=1235191&view=diff
>  ==============================================================================
>  --- xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFontLoader.java
(original)
>  +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFontLoader.java
Tue Jan 24 10:02:36 2012
>  @@ -173,7 +173,7 @@ public class TTFFontLoader extends FontL
>                if (ttf.isEmbeddable()) {
>                    returnFont.setEmbedFileName(this.fontFileURI);
>                } else {
>  -                String msg = "The font " + this.fontFileURI + " is not embedabble.";
>  +                String msg = "The font " + this.fontFileURI + " is not embeddable.";
>                    throw new RuntimeException(msg);
>                }
>            }
>
>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: fop-commits-unsubscribe@xmlgraphics.apache.org
>  For additional commands, e-mail: fop-commits-help@xmlgraphics.apache.org
>
>
>


Mime
View raw message