xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 52206] [PATCH] Small performance improvements by adding static declarations
Date Mon, 05 Dec 2011 15:39:15 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=52206

Vincent Hennebert <vhennebert@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Vincent Hennebert <vhennebert@gmail.com> 2011-12-05 15:39:15 UTC
---
Patch applied in rev. 1210477:
http://svn.apache.org/viewvc?rev=1210477&view=rev

As discussed, in PropertyMaker I store the log status in a static
IS_LOG_TRACE_ENABLED variable. I still wonder though if logs really are the
appropriate tool for this kind of thing. They add clutter to the code and are
useful probably only during the development phase. After that they could be
removed and replaced with unit tests. Plus the small but sometimes
non-negligible performance impact as found out by Alexis.

Thanks for this useful profiling session!

Vincent

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Mime
View raw message