xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 46962] [PATCH] Deadlock in PropertyCache class
Date Thu, 15 Sep 2011 12:09:38 GMT

--- Comment #10 from Alexis Giotis <alex.giotis@gmail.com> 2011-09-15 12:09:38 UTC ---
Medhi, thanks for checking & fixing checkstyle issues. Using the Property.eq()
definitely makes the equals() methods easier to read. I used the eclipse auto
generated equals() methods to avoid making any mistake because I did not add
the unit tests that you did. 

The only line I would delete is a 
        // TODO Auto-generated method stub
that is found in NCnamePropertyTestCase.java

I guess the issues related to the usage of Mockito and the etiquette for
replacing older work, are not for me to comment. I can only say that I checked
your changes over my patch and I find them very good. I have also applied my
previous patch on production and it works fine.

Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

View raw message