xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 46962] [PATCH] Deadlock in PropertyCache class
Date Wed, 14 Sep 2011 15:22:44 GMT

Mehdi Houshmand <med1985@gmail.com> changed:

           What    |Removed                     |Added
  Attachment #27477|0                           |1
        is obsolete|                            |

--- Comment #9 from Mehdi Houshmand <med1985@gmail.com> 2011-09-14 15:22:44 UTC ---
Created attachment 27495
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27495
propery cache patch

I've made a few changes to this patch a little:
- Created a static method Property.eq() which tests for object equality (and
reference equality for performance reasons)
- Fixed some checkstyle issues, these were not specific to this patch but
rather fixed some issues as I went along
- Unit tests have been added

Some of the tests added require Mockito, I tried to avoid using mocking as much
as possible for the obvious reason that the commiters haven't agreed to add it
as a dependency. However, some of these classes were are a nightmare to test
without mocking them.

This patch makes the previous work obsolete, I don't know what the etiquette is
when making someone else's work obsolete. I mean no offence.

Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

View raw message