xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From darshan <u4729...@anu.edu.au>
Subject Re: Want to contribute
Date Sun, 22 May 2011 17:47:52 GMT
Hi Andreas,

Thank you for the reply. I created a diff file and then wrote the 
checks, but I couldn't figure how to verify if the test was working. 
Also since the page http://xmlgraphics.apache.org/fop/dev/testing.html 
does not specify how I should submit the test file, I'm attaching the 
files with this mail. If this is not the right way then please guide me 
to submit the file properly.

To run the test, I tried by putting the file in the 
test/layoutengine/standard-testcases  folder and then setting the 
variable "-Dfop.layoutengine.starts-with" to my test file name, but it 
didn't run the test. If you could also let me know how to verify if the 
test works then that would be great.

Lastly for my report I need to write who started the project and what 
was the reason for starting the project. I know that James Tauber 
started the project but could you please tell me why he started it?

Thank you,
Darshan

On 17/05/11 06:14, Andreas L. Delmelle wrote:
> On 15 May 2011, at 07:18, darshan wrote:
>
> Hi Darshan
>
>> Thank you all for answering my questions. I could run the test cases using the variables
in eclipse. That was great! Should I update the wiki so that other it will be easier for other
people using eclipse?
> Yes, if you think that is useful, then by all means, go ahead. Thanks!
>
>> For the bug report 47279 from my previous mail, the bug seems to have been fixed
so can it's status be changed to resolved?
> If it is really fixed somehow, then I'd definitely start by adding a comment that describes
how you verified this. If the reporter challenges your assessment, he will reopen anyway,
so it does no harm to close it if you are convinced.
>
>> Lastly the bug report https://issues.apache.org/bugzilla/show_bug.cgi?id=50196 was
reopened because there was no test case for the fix. I have reproduced the error by modifying
one of the existing layout test files. The xml file and the output pdfs are attached. However
I could not figure out how to write the checks. How can I know which xpath elements should
have what values? Could you please guide as to how I can write the checks?
> You will want to take a look at the generated area tree XML in the build/test-results
folder (or wherever you have the output sent to). Locate the elements in the tree that play
a part in the issue, and figure out which attribute values to check.
>
> Note: if you leave the<checks>  element empty, you will still always get a default
check for a non-empty areaTree node. I added this once, to have a generic way to check for
simple things, like not throwing a NullPointerException, but I see it is not mentioned on
the Wiki...
>
> Hope this helps!
>
> Regards
>
> Andreas


Mime
View raw message