xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 50725] New: KnuthSequence documentation?
Date Sun, 06 Feb 2011 17:17:13 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=50725

           Summary: KnuthSequence documentation?
           Product: Fop
           Version: 1.1dev
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: page-master/layout
        AssignedTo: fop-dev@xmlgraphics.apache.org
        ReportedBy: adelmelle@apache.org


Created an attachment (id=26614)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26614)
proposed patch to deal with TODO, uncovers to a new one...

Attached is a patch against fop.layoutmgr.KnuthSequence, which takes care of a
TODO (Do not extend ArrayList) by implementing the List interface via proxy
methods to a member list.

Reason this is not committed yet, is that I wanted to go a step further and add
type safety to this class, but noticed that this is currently impossible. 
The explanation is also added in a new TODO: there is an inconsistency (or at
least incongruency) between block-layout and inline-layout. Block-layout works
mainly with KnuthSequences as List<ListElement>  where inline-layout seems to
expect List<KnuthSequence>...

Suggestions? Ideas? I would like to see those aligned, and in theory, once
KnuthSequence implements List, it is free to extend ListElement, if that would
be appropriate. The other way around could also make sense: consider each
ListElement as a KnuthSequence of a single element. Although that would require
some more refactoring, since we have to extract the KnuthSequence/List
interface before ListElement can implement it.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Mime
View raw message