xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Glenn Adams <gl...@skynav.com>
Subject Re: new checkstyle warnings, findbugs in trunk
Date Tue, 15 Feb 2011 21:23:20 GMT
Thanks. I would love DIY, but I would probably still ask whomever made the
commit that introduced the warnings to make the fix. I don't know who
introduced this set of warnings, and I appreciate it if you are fixing
someone's else warnings, but *really* folks, we all need to take the short
amount of time necessary to run these tools and fix problems before commits.

It really doesn't take much effort and promotes good habits. Kind of like
brushing your teeth before bed.


On Tue, Feb 15, 2011 at 1:57 PM, Andreas Delmelle <
andreas.delmelle@telenet.be> wrote:

> On 15 Feb 2011, at 19:21, Glenn Adams wrote:
> > Please fix the 2 new checkstyle warnings and 9 new findbug errors in
> trunk. In the future, please check and fix before committing.
> People, when are we going to vote Glenn a committer, so we can answer with
> three simple words/letters... DIY ;-) Just kidding, Glenn. Again, I
> appreciate the vigilance, but I simply refuse to clean up /everything/.
> If it's one I introduced, definitely no problem. Also no problem with
> rectifying mere style errors, but no one is ever going to learn from
> Findbugs' bad practice warnings unless they fix them themselves.
> Checkstyle has been taken care of. For the findbug errors, can the
> respective committer(s) please take a look? Seems like it will not be too
> much work, but would be much appreciated. Thanks!
> Regards,
> Andreas
> ---

View raw message