xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vincent Hennebert <vhenneb...@gmail.com>
Subject Re: svn commit: r742766 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf: PDFT1Stream.java PDFTTFStream.java
Date Tue, 10 Feb 2009 11:33:43 GMT
> Author: jeremias
> Date: Mon Feb  9 22:09:40 2009
> New Revision: 742766
> 
> URL: http://svn.apache.org/viewvc?rev=742766&view=rev
> Log:
> There was a filter list constant for fonts, but our font streams didn't use it.
> 
> Modified:
>     xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFT1Stream.java
>     xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFTTFStream.java
> 
> Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFT1Stream.java
> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFT1Stream.java?rev=742766&r1=742765&r2=742766&view=diff
> ==============================================================================
> --- xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFT1Stream.java (original)
> +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFT1Stream.java Mon Feb  9 22:09:40
2009
> @@ -87,4 +87,14 @@
>          this.pfb = pfb;
>      }
>  
> +    /** {@inheritDoc} */
> +    protected void setupFilterList() {
> +        if (!getFilterList().isInitialized()) {
> +            getFilterList().addDefaultFilters(
> +                getDocumentSafely().getFilterMap(),
> +                PDFFilterList.FONT_FILTER);
> +        }
> +        super.setupFilterList();
> +    }
> +
>  }
> 
> Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFTTFStream.java
> URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFTTFStream.java?rev=742766&r1=742765&r2=742766&view=diff
> ==============================================================================
> --- xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFTTFStream.java (original)
> +++ xmlgraphics/fop/trunk/src/java/org/apache/fop/pdf/PDFTTFStream.java Mon Feb  9 22:09:40
2009
> @@ -70,4 +70,14 @@
>          getBufferOutputStream().write(data, 0, size);
>      }
>  
> +    /** {@inheritDoc} */
> +    protected void setupFilterList() {
> +        if (!getFilterList().isInitialized()) {
> +            getFilterList().addDefaultFilters(
> +                getDocumentSafely().getFilterMap(),
> +                PDFFilterList.FONT_FILTER);
> +        }
> +        super.setupFilterList();
> +    }
> +
>  }

And yet another copy-paste. Was that really impossible to factorize this
piece of code in a common super class?

Vincent

Mime
View raw message