xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 46705] [PATCH] Enhancement: PDF Accessibility
Date Mon, 16 Feb 2009 13:54:08 GMT

--- Comment #4 from Jeremias Maerki <jeremias@apache.org>  2009-02-16 05:54:06 PST ---
Generally, the patch looks pretty good to me, besides the NPE which I know Jost
is already working on a fix for. That particular bug occurs because the
stylesheets get loaded via java.io.File instead of Class.getResource(AsStream).

I've got a few nits which I'll gladly address myself after we've applied to
patch to a temporary branch:

- FOUserAgent: set/getResult are not very speaking names for what they do. It
might also be better to just save a DOM instead of a byte array.
- area/inline/Image: ptr is normally set as a trait in the area tree but not
for the Image area. That can be homogenized.
- I'd rename fox:alt to a more speaking fox:alt-text.
- Some classes have just non-semantic changes (like commented code that is
never used or unnecessary "final" modifiers which look like they have come from
"Save Actions" in Eclipse). I'll remove those while processing the patch to
reduce the noise.
- There are some backwards-incompatible changes in the Renderer implementations
which are avoidable.
- I'd like to avoid adding the "ptr" attribute to the IFPainter methods since
most implementations don't support that anyway. I'd rather do it via the
IFContext like I've done for the foreign attributes.
- Static code analysis indicates a bug in PDFImageHandlerSVG concerning the
save/restore pairs.
- I'd move the FO -> PDF Struct Type mapping (in PDFStructElem) out of the PDF
library into the render/pdf package (separation of concerns and opening an
option for a later implementation of a custom role map).

Please speak up if anyone objects to any of these proposed changes.

Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

View raw message