xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 46315] fox:needs-balancing extension
Date Mon, 01 Dec 2008 12:18:45 GMT

Vincent Hennebert <vhennebert@gmail.com> changed:

           What    |Removed                     |Added
  Attachment #22970|0                           |1
        is obsolete|                            |

--- Comment #2 from Vincent Hennebert <vhennebert@gmail.com>  2008-12-01 04:18:44 PST
Created an attachment (id=22971)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22971)
Version 1, modified to basically do the job

Hi Georg,

Thanks for the patch. This is basically what needs to be done. I attach a
modified version of your patch with the following comments:
- you don't need to do anything on the Flow object actually. Since the property
is defined as inherited, the property sub-system will take care of this
- it's best to move the definition of the property from the
createBlockAndLineProperties method to createLayoutProperties (where the span
property is also defined)
- you can re-use the genericBoolean field in FOPropertyMapping
- the default value is true and not inherit. The inherit characteristic is
defined separately
- you can't play with LayoutContext in that way. The value of the property
needs to be known before Knuth elements are added to the element list (I don't
want to enter the details too much). Your best bet is to mimic the way the span
property is handled, see FlowLayoutManager in the attached patch

Please have a look at the attached patch; it worked for me on a basic example
but more extensive testing is needed. To ensure it doesn't break anything you
can run 'ant junit' on the command line at the base of the project. It will run
all the test and print a big fat warning in case one is broken.

Next step:
- clean up a bit
- make the modifications adhere to FOP's standard (see checkstyle-4.0.xml at
the root of the project)
- add a test case for the new feature (see the
test/layoutengine/standard-testcases/ directory)


Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

View raw message