xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From b.ohns...@freenet.de
Subject Re: Re: Code styleguide - protected variables vs. public/private concepts
Date Tue, 07 Mar 2006 16:48:41 GMT

----- original Nachricht --------

Betreff: Re: Code styleguide - protected variables vs. public/private concepts
Gesendet: Di 07 Mär 2006 17:28:22 CET
Von: "Manuel Mall"<mm@arcus.com.au>

> On Wednesday 08 March 2006 00:00, b.ohnsorg@freenet.de wrote:
> > Hi there,
> >
[...]
> > package org.apache.fop.layoutmgr.table;
> > [...]
> >
> >     public TableCellLayoutManager(TableCell node, PrimaryGridUnit
> > pgu) { super(node);
> >         fobj = node;
> >         this.gridUnit = pgu;
> >     }
> > [...]
> >
> There is another scenario: It was simply forgotten to adjust during a 
> refactoring. If you look closely there are quite a few of these 
> 'little' things scattered through code base. For example 
> TableAndCaptionLayoutManager and TableCaptionLayoutManager have the 
> same 'defect' of setting the fobj member.
[...]
> Manuel
> 
Mkay, this is what I wanted to hear *g*. My ToDo's full but definitely an issue that should
be fixed before releasing 1.0. Sometimes these little things sum up to become an adult bug...









Mime
View raw message