xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Clay Leeds <webmaes...@mac.com>
Subject Re: [VOTE] Finalized API - Merge Temp_API_Finalization branch back into Trunk
Date Tue, 21 Mar 2006 17:00:40 GMT
These changes look like a move in the right direction... Glad to hear  
we're nearing another release again!

On Mar 21, 2006, at 6:23 AM, Jeremias Maerki wrote:
> We need to finish the API discussion once and for all, especially  
> since
> we need to get another release out of the door soon. I'm happy with  
> the
> API as described in [1] and implemented in the Temp_API_Finalization
> branch, except for one item handled separately below. Thanks to Simon
> for cleaning up the branch and rewriting the examples.
>
> 1. I'd like to propose merging back the Temp_API_Finalization branch
> back into Trunk.
>
> +1 from me (I can do the actual merge)

+1

> 2. This is somewhat detached from point 1 above, so I put it in a  
> second
> item. Jess Holle asked in [2][3] to leave the existing Fop  
> constructors
> intact. ATM, only one is deprecated. In D8 in [1], I proposed to
> deprecate all Fop constructors.
>
> I thought some more about this and I'm for drawing a clean line. So:
>
> +1 from me for deprecating all Fop constructors, even if it means that
> some people have to adjust their code. After all, we're still on
> beta-level and have clearly indicated that the API isn't stable, yet.

+1

> Removing the reflection code from Jess' example, it looks like this:
>
>     Fop fop = new Fop("application/pdf");
>     fop.setOutputStream(out);
>     DefaultHandler defaultHandler = fop.getDefaultHandler();
>
> With the revised API, this will need to be changed to this:
>
>     Fop fop = FopFactory.newInstance().newFop("application/pdf", out);
>     DefaultHandler defaultHandler = fop.getDefaultHandler();
>
> Simon's deprecating setOutputStream() gives me the impression that  
> he'd
> be in favor of that, too, but obviously I can't speak for him. But it
> points in the same direction.
>
>
> [1] http://wiki.apache.org/xmlgraphics-fop/ApiDesign
> [2] http://mail-archives.apache.org/mod_mbox/xmlgraphics-fop-dev/ 
> 200602.mbox/%3c43E86C88.2050308@ptc.com%3e
> [3] http://mail-archives.apache.org/mod_mbox/xmlgraphics-fop-dev/ 
> 200602.mbox/%3c43E8A17C.6060409@ptc.com%3e
>
> Jeremias Maerki

+1 for all changes described above.

Clay Leeds
webmaestro@mac.com

My religion is simple. My religion is kindness.
-- HH Dalai Lama of Tibet




Mime
View raw message