xmlgraphics-fop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simon Pepping <spepp...@leverkruid.nl>
Subject Re: Setting up the output format
Date Mon, 16 Aug 2004 20:31:51 GMT
I like the way all constants are collected in one class. I do not like
the fact that many classes implement this interface. The jdee debugger
is much hindered by it, because it makes each object very large, with
so many constants. Why is Constants not just imported?

Regards, Simon

On Sun, Aug 15, 2004 at 04:48:48PM -0700, Glen Mazza wrote:
> --- Jeremias Maerki <dev.jeremias@greenmail.ch> wrote:
> > One thing I didn't really like was the fact the Fop
> > class implements
> > Constants. 
> Well, the render constants used to be redundantly
> defined in both CommandLineOptions.java and
> Driver.java.  I centralized them, and defined them in
> one place, fo.Constants, where we keep our other
> system-only constants--for properties, FO's, etc. 
> (fo.Constants was originally created from Finn's work
> with the properties--I just added these constants to
> it.)
> > From a user's POV this renders the code
> > completion (in
> > Eclipse, for example) virtually useless as there are
> > simply too many
> > (unused) items.
> > 
> Yes, the Constants class is somewhat large--it has
> render types, fo and properties constants.  But it's
> not unmanageable, and the issue of Eclipse showing too
> many constants is going to be relevant in most of the
> application.  It is implemented both by the FO's and
> the LM's, and every class needs just a little bit of
> that file--a few FO's or a few properties, etc.
> But it has not been a problem to me, I work on the
> code rather heavily.  Neither have Finn, Simon or
> Chris mentioned this--and by virtue of working in
> Layout and FOTree, they would presumably come across
> this problem much more often.  

Simon Pepping
home page: http://www.leverkruid.nl

View raw message