sis-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject svn commit: r1600770 - /sis/ip-review/rev/27154/ProjectiveTransform2D.xhtml
Date Thu, 05 Jun 2014 21:24:39 GMT
Author: desruisseaux
Date: Thu Jun  5 21:24:39 2014
New Revision: 1600770

More details on the process followed for rewriting a code.


Modified: sis/ip-review/rev/27154/ProjectiveTransform2D.xhtml
--- sis/ip-review/rev/27154/ProjectiveTransform2D.xhtml (original)
+++ sis/ip-review/rev/27154/ProjectiveTransform2D.xhtml Thu Jun  5 21:24:39 2014
@@ -14,6 +14,21 @@
 This is the smallest possible implementation of a two-dimensional <code>ProjectiveTransform</code>.
 There is no way to do the minimalist version otherwise,
 except for Javadoc and the <code>public</code> modifier of constructor.</p>
+<p>This contribution has been redone as below:</p>
+  <li>Create a new class for a 2D transform using the same naming convention than all
other classes in this package,
+      namely "BaseClassName + 2D".</li>
+  <li>Extend the base class, namely <code>ProjectiveTransform</code>.</li>
+  <li>The compiler complains that there is no default constructor to inherit from the
parent class.
+      Fix the compiler error by adding a constructor with the same parameter than the parent
+      and just pass that parameter to the parent class constructor.</li>
+  <li>Implement <code>MathTransform2D</code>, which is the whole purpose
of this class.</li>
+<p>And we are done (ignoring all abstract methods that we need to implement).
+However while this contribution has been trivially be redone,
+we nevertheless keep the original author name for credit.</p>
 <p><b>Command line:</b></p>
 <blockquote><code>svn diff --extensions "--unified --ignore-space-change --ignore-all-space
--ignore-eol-style" -r27153:27154</code></blockquote>
 <table class="changes">

View raw message