portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vivek Kumar (JIRA)" <jetspeed-...@portals.apache.org>
Subject [jira] Assigned: (JS2-848) Portlet decorator comboboxes doesn't displays current decorator name (and tiny performance degradation)
Date Mon, 13 Oct 2008 10:24:44 GMT

     [ https://issues.apache.org/jira/browse/JS2-848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Vivek Kumar reassigned JS2-848:
-------------------------------

    Assignee: Vivek Kumar

> Portlet decorator comboboxes doesn't displays current decorator name (and tiny performance
degradation)
> -------------------------------------------------------------------------------------------------------
>
>                 Key: JS2-848
>                 URL: https://issues.apache.org/jira/browse/JS2-848
>             Project: Jetspeed 2
>          Issue Type: Bug
>          Components: Customizer
>    Affects Versions: 2.1.3
>            Reporter: Vitaly Baranovsky
>            Assignee: Vivek Kumar
>         Attachments: layout_vm.patch
>
>
> When I change decorator of some portlet using the customizer, decorator changes without
any problem, but name of decorator doesn't displays in decorator combobox of customizer.
> The problem is inside WEB-INF\templates\layout\html\columns\layout.vm.
> Problem is in code (2 times per this file):
>                 #if (!$f.Decorator)
>                     #set ($fd = $f.Decorator)
>                 #end
> You should change first line of this code block to
>                #if($f.Decorator).
> Also, there is code block:
>         	    #foreach($pd in $decorationFactory.getPortletDecorations($rc))
>                 #set ($fd = "")
>                 #if (!$f.Decorator)
>                     #set ($fd = $f.Decorator)
>                 #end
>             <option value='$pd' #if ($pd == $fd) SELECTED #end>$pd
>         	    #end
>           </select>
> code of setting $fd is inside the cycle, but $fd is never changes inside this cycle.
So, there is a good idea to move this setting block before cycle.
> Patch that solves this problem is attached to this JIRA record.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message