portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vitaly Baranovsky" <vitaly.baranovsk...@gmail.com>
Subject Re: high memory consumption, possible fix
Date Wed, 07 Nov 2007 14:49:07 GMT
As far as I understand, nor JS2-800 nor JS2-801 doesn't concern second
fix proposed by Joahim Muller:
> The second fix addresses the release of all attributes from velocity
> context incl. removing cycling references in the
> JetspeedVelocityViewServlet (service method):
>
> ...
> Context ctx = (Context) renderRequest.getAttribute (VELOCITY_CONTEXT_ATTR);
>
> renderRequest.removeAttribute(VELOCITY_CONTEXT_ATTR);
> renderRequest.removeAttribute (PortalReservedParameters.JETSPEED_POWER_TOOL_REQ_ATTRIBUTE);
>
>JetspeedVelocityPowerTool jpt = (JetspeedVelocityPowerTool)
> ctx.get(JETSPEED_TOOL_VAR_NAME);
>
> if (jpt!=null){
>        jpt.setVelocityContext(null);
>        ctx.remove(JETSPEED_TOOL_VAR_NAME);
> }
>
> Object[] keys = ctx.getKeys();
> //Delete all attributes
> for (int i = 0; i < keys.length; i++) {
>        ctx.remove(keys[i]);
> }
> ...


Or not?

2007/11/7, Weaver, Scott <weavers@ugs.com>:
> Hi Vitaly,
>
> This is a known issue (I am encountering it as well).  Please look at JS2-800 and J2-801.
 I am currently testing JS2-800 and the changes seem to have helped quite a bit.
>
> -scott
>
> > -----Original Message-----
> > From: Vitaly Baranovsky [mailto:vitaly.baranovsky.2@gmail.com]
> > Sent: Wednesday, November 07, 2007 4:51 AM
> > To: Jetspeed Developers List
> > Subject: Re: high memory consumption, possible fix
> >
> > Hi all!
> >
> > We have same problem too. We have jetspeed-based web-site with twenty
> > thousand clients per days. JVM use 3Gb (1Gb per Eden and 2Gb per
> > Tunured mem space). Eden is full after 20 sec!! So, we have minor GC
> > after every 20 sec and Full GC after every 10-15 minutes. It slowdons
> > our system. And after 5-6 days there is out of heap space (I don't
> > know yet jetspeed causes it or not).
> >
> > There is a need to optimize jetspeed memory consumption.
> >
> > I propose to open new JIRA record for optimizing memory consumption. I
> > think it would be good to do this with 2.1.3 release, because Jetspeed
> > 2.2 will be release after a long time, but high memory consumption is
> > important problem.
> >
> > 2007/11/6, Joachim Müller <joachim@wemove.com>:
> > > Hi all,
> > >
> > > we are experiencing very high memory consumption on a system based on
> > > Jetspeed 2.1 under very high load. (OutOfMemory within a couple of
> > minutes)
> > >
> > > There are 2 fix that are proposed to us. First addresses the decoupling
> > > of the PortletContent from all ContentFragments of a page in
> > > CleanupValveImpl:
> > >
> > > ((ContentFragment)fragment).setPortletContent(null);
> > >
> > >
> > > The second fix addresses the release of all attributes from velocity
> > > context incl. removing cycling references in the
> > > JetspeedVelocityViewServlet (service method):
> > >
> > > ...
> > > Context ctx = (Context)
> > renderRequest.getAttribute(VELOCITY_CONTEXT_ATTR);
> > >
> > > renderRequest.removeAttribute(VELOCITY_CONTEXT_ATTR);
> > >
> > renderRequest.removeAttribute(PortalReservedParameters.JETSPEED_POWER_TOOL
> > _REQ_ATTRIBUTE);
> > >
> > > JetspeedVelocityPowerTool jpt = (JetspeedVelocityPowerTool)
> > > ctx.get(JETSPEED_TOOL_VAR_NAME);
> > >
> > > if (jpt!=null){
> > >        jpt.setVelocityContext(null);
> > >        ctx.remove(JETSPEED_TOOL_VAR_NAME);
> > > }
> > >
> > > Object[] keys = ctx.getKeys();
> > > //Delete all attributes
> > > for (int i = 0; i < keys.length; i++) {
> > >        ctx.remove(keys[i]);
> > > }
> > > ...
> > >
> > > (already adapted to 2.1.2)
> > >
> > >
> > > Since this is kind of rough I would like to discuss this with the
> > > developer list.
> > >
> > > I also know, that Scott was working on replacing the standard hashmap
> > > caching in org.apache.jetspeed.profiler.impl.JetspeedProfilerImpl and
> > > org.apache.jetspeed.container.window.impl.PortletWindowAccessorImpl.
> > > Scott, can you already share some of your results?
> > >
> > > Best regards,
> > > Joachim
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
> > > For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
> > >
> > >
> >
> >
> > --
> > With best regards,
> > Vitaly Baranovsky
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
> > For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
> For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
>
>


-- 
With best regards,
Vitaly Baranovsky

---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


Mime
View raw message