portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Woonsan Ko (JIRA)" <jetspeed-...@portals.apache.org>
Subject [jira] Created: (JS2-619) Non-thread safe code in PortalSiteRequestContextImpl.java
Date Mon, 04 Dec 2006 12:27:23 GMT
Non-thread safe code in PortalSiteRequestContextImpl.java

                 Key: JS2-619
                 URL: http://issues.apache.org/jira/browse/JS2-619
             Project: Jetspeed 2
          Issue Type: Bug
          Components: Components Core
    Affects Versions: 2.1-dev
         Environment: Any environment.
            Reporter: Woonsan Ko
            Priority: Minor

Every header.vm calls $site.getMenu(...) to retreive menus for a folder.
And the class, named 'org.apache.jetspeed.portalsite.impl.PortalSiteRequestContextImpl', manages
a set and a map to store and query portlet definition names and menus.

However, because those are instantiated as a HashSet and as a HashMap, JS2 can throw ConcurrentModificationException
when portlet definitions and menus are to be cached.

This exception can be observed in the following case:
  - For some reason, user can request twice for the same folder.
  - For some reason, a developer can design the pages to call header.vm simultaneously.
(Actually these situations are not usual and it may not occur after first visit for a folder,
but it can occur.)

Therefore, those are to be synchronized.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org

View raw message