portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aurelien Pernoud" <apern...@sopragroup.com>
Subject RE: cvs commit: jakarta-jetspeed/src/java/org/apache/jetspeed/portal BasePortletSkin.java PortletSkin.java
Date Fri, 28 Mar 2003 08:11:14 GMT

Hi Scott,

I've seen your bug report at first, and then the changes you commited, but i
think your changes makes it a little "messy" to define a skin that will
change every action images. Even if I like the idea of changing actions
image, I think there is a better and simpler way to do it. Here is my
opinion :

- When you want to change the actions image , if you want your skin to be
nice, every images will have to look "the same", I mean you won't put a blue
restore with a yellow maximize (??).
- Imagine I want to change all the action buttons, I have to enter in my
skin like 5 entries.
- My skin can refer any subdirectory (your sample said
images/rk/icons/actions/1/restore.gif, that's cool, but again, if you like
your portal to be "clear", you put all the images of one skin in the same
directory...)
- I'm making a new action for my portlets, I have to update all of my skins
(exception made if you find an icon that fits with all of your existing
icons and skins, but I really don't think it's possible).

That's why after looking your changes I've thought of another way to do it :

According that everything above is logic (again, it's my thought, I don't
want to offense anyone), why not see it this way :

I want to change the actions image of my skin, ok, I put something like
<property name="actions-image-path"
value="the_path_to_my_icons_for_this_skin" hidden="false"/>

And then during rendering, if the above property is in the skin, I change
the path for actions :
<img src="${skin.getImagePath()/${action.Name}.gif")}>, according the method
returns "image" if the property isn't in the skin.

Advantages :
- One entry in the skin
- Every graphics for one skin in the same subdirectory, which allow better
portal structure
- I make a new action, all I have to do for my existing skins is to put the
associate gif in the right directory. No changes to xreg
- I want to reorganize my skins directory, I simply have to change one
property in my existing skins

Inconvenients :
- all your graphics have to be named by the action Name, and they must be
GIF...
- you can't mix action graphics from different subdirectories (but is it a
need ?)

Sorry for pointing this after you commited the changes, but I didn't think
you would make them so fast :)
BTW, while you're working on skins, could you tell me what you think of my
proposal for skins :
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18188

I'm using this changes here and this allows really nice skins, even if the
one that comes with my sample isn't the best (I did it... and I'm really not
a good graphist, every one is job ! ;))
It might need a little more documentation on how to use those changes, but
if you're familiar with css, you'll get it.

Sincerely,
Aurelien


weaver@apache.org a écrit :

> BasePortletSkin.java PortletSkin.java
>
>
> weaver      2003/03/27 09:46:20
>
>   Modified:    webapp/WEB-INF/templates/vm/controls/html jetspeed.vm
>                src/java/org/apache/jetspeed/portal
> BasePortletSkin.java
>                         PortletSkin.java
>   Log:
>   Bug ID: 18208 "Allow skinning of action icons"
>
>   - Portlets using the jetspeed.vm can now have "skinned" action
>     icons. This is acheived by creating properties within the skin in
>     the format of "image-{action name}".  If these are not defined,
> the original icons are used.
>
>   - Removed redundant "public" modifiers within the
> PortletSkin interface per Checkstyle recommendation.


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org


Mime
View raw message