portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Santiago Gala <sg...@hisitech.com>
Subject Re: cvs commit: jakarta-jetspeed/xdocs changes.xml
Date Wed, 19 Mar 2003 20:57:03 GMT
morciuch@apache.org wrote:
> morciuch    2003/03/18 12:06:27
> 
>   Modified:    .        project.xml
>                build    build.xml
>                docs/site changes.html
>                xdocs    changes.xml
>   Log:
>   1. Fixed 'war_release' target to exclude .class files from the .war file (see Bugzilla
issue# 18121).

1. excludes the jar, includes the .class files. But see below:

>   
>   2. Updated dependencies for the maven build. Tested jar and war goals - OK.

I get
[sgala@patusan jakarta-jetspeed]$ LANG=en 
~/jakarta/maven-1.0-beta-8/bin/maven clean
  __  __
|  \/  |__ Jakarta _ ___
| |\/| / _` \ V / -_) ' \  ~ intelligent projects ~
|_|  |_\__,_|\_/\___|_||_|   v. 1.0-beta-8


Attempting to download jakarta-oro-2.0.6.jar.
Attempting to download jakarta-regexp-1.2.jar.
Attempting to download jaxp-1.2.jar.
Attempting to download jdbc-2.0.jar.
Attempting to download jndi-1.2.1.jar.
Attempting to download stratum-1.0-b4-dev.jar.
Attempting to download uddi4j-1.0.jar.
Attempting to download cactus-22-1.2.jar.
Attempting to download cactus-ant-1.2.jar.
clean:clean:
     [delete] Deleting directory 
/home/sgala/jakarta/cleanclean/jakarta-jetspeed/target
BUILD SUCCESSFUL
Total time:  27 seconds

which means that maven cannot find the named files above, and then jar 
give >100 errors (related to the missing jars)

I needed to apply this patch:

[sgala@patusan jakarta-jetspeed]$ cvs diff -u project.xml
Index: project.xml
===================================================================
RCS file: /home/cvs/jakarta-jetspeed/project.xml,v
retrieving revision 1.11
diff -u -r1.11 project.xml
--- project.xml	18 Mar 2003 20:06:25 -0000	1.11
+++ project.xml	19 Mar 2003 20:46:15 -0000
@@ -212,14 +212,14 @@
  			</properties>
  		</dependency>
  		<dependency>
-			<id>jakarta-oro</id>
+			<id>oro</id>
  			<version>2.0.6</version>
  			<properties>
  				<war.bundle.jar>true</war.bundle.jar>
  			</properties>
  		</dependency>
  		<dependency>
-			<id>jakarta-regexp</id>
+			<id>regexp</id>
  			<version>1.2</version>
  			<properties>
  				<war.bundle.jar>true</war.bundle.jar>
@@ -360,11 +360,11 @@
  		</dependency>
  		<dependency>
  			<id>cactus</id>
-			<version>22-1.2</version>
+			<version>12-1.4.1</version>
  		</dependency>
  		<dependency>
-			<id>cactus-ant</id>
-			<version>1.2</version>
+			<id>cactus</id>
+			<version>ant-1.4.1</version>
  		</dependency>
  		<dependency>
  			<id>junit</id>

*and* copy the lib/uddi4j.jar and lib/stratum-1.0-b4-dev.jar to the 
maven repository like:

[sgala@patusan jakarta-jetspeed]$ cp lib/uddi4j.jar 
~/jakarta/maven-1.0-beta-8/repository/uddi4j/jars/uddi4j-1.0.jar

To get a clean build. This is because there is no uddi4j directory in 
maven's repository, neither version 1.0-b4-dev of stratum. I'm not sure 
if repeating the "cactus" id will work in an empty repository. (I had 
already the cactus files there).

Also, I have not tested the build yet

(...)
>   Index: build.xml
>   ===================================================================
>   RCS file: /home/cvs/jakarta-jetspeed/build/build.xml,v
>   retrieving revision 1.185
>   retrieving revision 1.186
>   diff -u -r1.185 -r1.186
>   --- build.xml	12 Feb 2003 05:56:49 -0000	1.185
>   +++ build.xml	18 Mar 2003 20:06:25 -0000	1.186
>   @@ -731,15 +731,6 @@
>            <war warfile="${build.dir}/${project.name}.war"
>                webxml="${webapp.dir}/WEB-INF/web.xml">
>    
>   -            <classes dir="${build.dest.dir}">
>   -                <!-- Do not include test files in the runtime jar -->
>   -                <exclude name="**/Test*.*"/>
>   -                <exclude name="**/test*.*"/>
>   -
>   -                <!-- Also exclude the test cactus.properties file -->
>   -                <exclude name="cactus.properties"/>
>   -            </classes>           
>   -                        
>                <lib dir="${lib.dir}">
>                    <include name="*.jar"/>                
>                    <exclude name="servlet*.jar"/>
>   
>   
>   

Why was this needed? I built the jar (with ant) after the change, and it 
contains the Test classes (which are of no purpose in it). I think this 
change should be reverted. In other words, I'm -1 on this change unless 
you explain why it is needed.

-- 
Santiago Gala
High Sierra Technology, S.L. (http://hisitech.com)
http://memojo.com?page=SantiagoGalaBlog



---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org


Mime
View raw message