portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Sean Taylor" <da...@bluesunrise.com>
Subject RE: Why is BaseJetspeedUser.setNew method package scope?
Date Thu, 25 Jul 2002 15:26:21 GMT


> -----Original Message-----
> From: Steve Davis [mailto:steve.davis@digitalevergreen.com]
> Sent: Thursday, July 25, 2002 7:50 AM
> To: jetspeed-dev@jakarta.apache.org
> Subject: Why is BaseJetspeedUser.setNew method package scope?
> 
> 
> I am trying to migrate to the new 1.4.b1 release. 
> We were extending the TurbineUser object. Now I want 
> to extend BaseJetspeedUser. I was wondering why the 
> setNew mthod is package scope instead of public like 
> all the other methods in this lass? If there is a reason 
> to limit access, shouldn't it at least be protected 
> scope so it can be easily extended? 

+1

> 
> Also I am wondering why in the save() method of this 
> class the logic checks to see if the this.isNew() and 
> if it is then it does a saveUser otherwise it does an 
> addUser. Isn't this backwards? 

Yes, thats a bug. I submit a patch today.

> 
> -- Steve Davis
> 
> 
> --
> To unsubscribe, e-mail:   
> <mailto:jetspeed-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: 
> <mailto:jetspeed-dev-help@jakarta.apache.org>
> 
> 


--
To unsubscribe, e-mail:   <mailto:jetspeed-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:jetspeed-dev-help@jakarta.apache.org>


Mime
View raw message