portals-jetspeed-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Sean Taylor" <da...@bluesunrise.com>
Subject RE: Opinion on log messages
Date Mon, 01 Jul 2002 19:50:53 GMT


> -----Original Message-----
> From: Glenn Golden [mailto:ggolden@umich.edu] 
> Sent: Monday, July 01, 2002 12:44 PM
> To: 'Jetspeed-Dev'
> Subject: Opinion on log messages
> 
> 
> I'm looking at JetspeedRunDataService, at the log messages.  
> There's on in each of the three routines.  These end up in 
> the jetspeed log quite a bit.
> 
> I was thinking about removing them.
> 
> But looking at them, they are good "debug" messages, even 
> perhaps good "info" messages - to give us a feel from looking 
> at the logs of what's going on.  They are also properly 
> guarded with an "if debug logging" test.

+1 for guarding all debug messages with "if debug logging"
Otherwise potentially complex statements will be evaluated, objects
created etc., for no reason at all
Jetspeed hasn't been to good about this in the past

> 
> So, I think I'll leave them, and if I don't want them, I turn 
> off debug logging.
> 
> I just want to check with the other developers to see if this 
> logic sits well with you.
> 
> Thanks.
> 
> - Glenn
> 
> --------------------------------------------
> Glenn R. Golden, Systems Research Programmer 
> University of Michigan School of Information
> ggolden@umich.edu               734-615-1419
> --------------------------------------------
> 
> --
> To unsubscribe, e-mail:   
> <mailto:jetspeed-dev-> unsubscribe@jakarta.apache.org>
> For 
> additional commands, 
> e-mail: <mailto:jetspeed-dev-help@jakarta.apache.org>
> 
> 



--
To unsubscribe, e-mail:   <mailto:jetspeed-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:jetspeed-dev-help@jakarta.apache.org>


Mime
View raw message