mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] qianzhangxa commented on pull request #403: Fixed cpplint errors.
Date Mon, 09 Aug 2021 23:45:40 GMT

qianzhangxa commented on pull request #403:
URL: https://github.com/apache/mesos/pull/403#issuecomment-895624470


   > I don't seem to have merge permissions yet?
   
   @cf-natali What we usually do is to run `support/apply-reviews.py -g <PR-number>`
(e.g. `support/apply-reviews.py -g 403` for this PR) to apply the changes of a PR on top of
the latest code of `master` branch, and then run `git push` to push the commit to the remote
(https://gitbox.apache.org/repos/asf/mesos.git) which will also automatically close the PR.
I think you already have the push permission now. Once the commit gets pushed, it will also
trigger a build in https://builds.apache.org/job/Mesos/job/Mesos-Buildbot/, we need to check
if that build has any failures.
   
   Please note, https://github.com/apache/mesos.git is just a mirror of https://gitbox.apache.org/repos/asf/mesos.git,
so I do not think we should directly merge MRs in it.
   
   Please also add yourself into https://github.com/apache/mesos/blob/master/docs/committers.md,
thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message