mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 73137: Avoid using the libev default loop.
Date Wed, 20 Jan 2021 21:28:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73137/
-----------------------------------------------------------

(Updated Jan. 20, 2021, 9:28 p.m.)


Review request for mesos and Ilya Pronin.


Changes
-------

Updates based on Ilya's review.


Repository: mesos


Description
-------

The default loop in libev supports child process events, which we
don't want and explicitly ignore. We can just use dynamic loops
instead which allows us to properly destroy the loop when libprocess
finalizes.

This also helps minimize the changes needed once we add support for
multiple loops, since those need to be dynamic loops as well.


Diffs (updated)
-----

  3rdparty/libprocess/src/posix/libev/libev.cpp b38e7a0f882a8c24950bdc6fd74a4d25fc68549e 


Diff: https://reviews.apache.org/r/73137/diff/2/

Changes: https://reviews.apache.org/r/73137/diff/1-2/


Testing
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message