mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [mesos] vinodkone commented on a change in pull request #371: [MESOS-10199] Fix Host field in client headers
Date Wed, 09 Dec 2020 23:48:47 GMT

vinodkone commented on a change in pull request #371:
URL: https://github.com/apache/mesos/pull/371#discussion_r539734862



##########
File path: 3rdparty/libprocess/src/tests/process_tests.cpp
##########
@@ -1463,12 +1465,17 @@ TEST_F(ProcessTest, Remote)
   message.name = "handler";
   message.from = UPID("sender", sender.get());
   message.to = process.self();
+  message.body = "hello world";
 
   const string data = MessageEncoder::encode(message);
 
   AWAIT_READY(socket.send(data));
 
-  AWAIT_READY(handler);
+  AWAIT_READY(body);
+  ASSERT_EQ("hello world", body.get());
+
+  AWAIT_READY(pid);
+  ASSERT_EQ(message.from, pid.get());

Review comment:
       Would this assert fail if HOST header is not set with a real ip port?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message