mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@apache.org>
Subject Re: Review Request 72956: Added validation that offer constraints are set only for existing roles.
Date Wed, 14 Oct 2020 18:18:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72956/
-----------------------------------------------------------

(Updated Oct. 14, 2020, 8:18 p.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-10176
    https://issues.apache.org/jira/browse/MESOS-10176


Repository: mesos


Description
-------

This patch makes SUBSCRIBE/UPDATE_FRAMEWORK calls validate that
the framework does not specify offer constraints for roles to which
it is not going to be subscribed.


Diffs (updated)
-----

  src/master/master.cpp d6d3ea7e27539a65b601783eca2ac4e3b688f188 
  src/master/validation.hpp 7fe8f087b322f8e77218f4dd9f9f75707afa3208 
  src/master/validation.cpp 5b1bcb5207aac0553bf9c1a0d89525c835393ccb 
  src/tests/master/update_framework_tests.cpp 3f86573e8dfeea63fe99064f2137c61d901f4fc7 


Diff: https://reviews.apache.org/r/72956/diff/2/

Changes: https://reviews.apache.org/r/72956/diff/1-2/


Testing
-------

`make check`
`src/mesos-tests --gtest_filter='*UpdateFrameworkTest.OfferConstraintsForUnsubscribedRole*'
--gtest_break_on_failure --gtest_repeat=1000`


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message