mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@apache.org>
Subject Re: Review Request 72922: Re-added the obsolete `updateFramework` signature into libmesos-java.so.
Date Fri, 02 Oct 2020 12:09:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72922/
-----------------------------------------------------------

(Updated Oct. 2, 2020, 2:09 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Changed comments style, added deprecation labels to the 2-parameter signature.


Bugs: MESOS-10189
    https://issues.apache.org/jira/browse/MESOS-10189


Repository: mesos


Description
-------

This patch converts the implementation of the obsolete 2-parameter
`SchedulerDriver.updateFramework(frameworkInfo, suppressedRoles)`
from a wrapper around the new signature back into a JNI method
that 930c7e98d17e71192dae1d49b4b2217cc2dbd8b2 attempted to remove.

This is needed to keep compatibility between older versions of
`mesos.jar` and newer versions of `libmesos-java.so`.


Diffs (updated)
-----

  src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 4efde3083bb62253f3ad512b40a291fd7f7f7a78

  src/java/src/org/apache/mesos/MesosSchedulerDriver.java 4fdae338491709574775c52438e41d03b39917bd



Diff: https://reviews.apache.org/r/72922/diff/2/

Changes: https://reviews.apache.org/r/72922/diff/1-2/


Testing
-------

`make check`


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message