mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 72922: Re-added the obsolete `updateFramework` signature into libmesos-java.so.
Date Thu, 01 Oct 2020 20:19:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72922/#review221984
-----------------------------------------------------------


Fix it, then Ship it!





src/java/src/org/apache/mesos/MesosSchedulerDriver.java
Line 411 (original), 411-414 (patched)
<https://reviews.apache.org/r/72922/#comment311059>

    Use javadoc style here?
    
    Also, can we put a @deprecated attribute?



src/java/src/org/apache/mesos/MesosSchedulerDriver.java
Lines 416-418 (patched)
<https://reviews.apache.org/r/72922/#comment311060>

    Use javadoc style here? maybe make this clear that it's a note for us and not the user
looking at the interface?


- Benjamin Mahler


On Oct. 1, 2020, 2:01 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72922/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2020, 2:01 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10189
>     https://issues.apache.org/jira/browse/MESOS-10189
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch converts the implementation of the obsolete 2-parameter
> `SchedulerDriver.updateFramework(frameworkInfo, suppressedRoles)`
> from a wrapper around the new signature back into a JNI method
> that 930c7e98d17e71192dae1d49b4b2217cc2dbd8b2 attempted to remove.
> 
> This is needed to keep compatibility between older versions of
> `mesos.jar` and newer versions of `libmesos-java.so`.
> 
> 
> Diffs
> -----
> 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 4efde3083bb62253f3ad512b40a291fd7f7f7a78

>   src/java/src/org/apache/mesos/MesosSchedulerDriver.java 4fdae338491709574775c52438e41d03b39917bd

> 
> 
> Diff: https://reviews.apache.org/r/72922/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message