mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <>
Subject Review Request 72886: Enforced explicit construction of `protobuf::...::Capabilities`.
Date Fri, 18 Sep 2020 16:56:37 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos and Benjamin Mahler.

Bugs: MESOS-10177

Repository: mesos


This makes Mesos code more compliant with the Google C++ styleguide's
rule banning implicit conversions for non-interchangeable types,
for which the Mesos styleguide makes no exception.

In particular, not enabling a type conversion from an iterable into
`Capabilities` disallows puzzling code that looks like copying the same
protobuf twice. Now, an example like
``` = info;
framework.capabilities = info.capabilities();`
can no longer occur.


  src/common/protobuf_utils.hpp 0558249023b39863b4030ddbcfe5c83dc945570a 
  src/master/allocator/mesos/hierarchical.cpp 47f8a2bfa267d68d39d2c255c7c97c8f213d5f69 
  src/master/master.cpp 54b24b4eb8824737b10b3b4d6d51f387360570a1 
  src/slave/slave.cpp a69937b73e25e26c51d4fe857782bb75396606c1 




Andrei Sekretenko

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message