mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <>
Subject Re: Review Request 72790: Deduplicated concurrent image pulls by docker store.
Date Thu, 03 Sep 2020 12:29:04 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 3, 2020, 12:29 p.m.)

Review request for mesos and Qian Zhang.


Added a comment for the pull hashmap; fixed indentation.

Bugs: MESOS-10169

Repository: mesos


This patch makes the docker store reuse a pending pull if asked for
an image that is already being pulled.

The pull caching follows the same approach as the earlier attempt in . However, handing out futures to
the store callers and handling their discards are performed differently,
using a form of reference counting, so that the pull itself is discarded
only if all the futures returned by `Store::get()` have been discarded.

Diffs (updated)

  src/slave/containerizer/mesos/provisioner/docker/store.cpp bf2be90aa4fcd7541849a157eb6930b491ccf03a





Andrei Sekretenko

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message