mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72409: Added intro docs on running workloads.
Date Wed, 29 Apr 2020 13:46:00 GMT


> On April 22, 2020, 10:09 p.m., Qian Zhang wrote:
> > docs/running-workloads.md
> > Lines 65-67 (patched)
> > <https://reviews.apache.org/r/72409/diff/1/?file=2224549#file2224549line65>
> >
> >     Do we want to mention how we set OOM score adjustment for burstable tasks somewhere
in the doc?
> >     
> >     And I think we also need to describe the newly introduced `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED`
in the doc `task-state-reasons.md`.
> 
> Greg Mann wrote:
>     I added these to https://reviews.apache.org/r/72410/ as well
> 
> Qian Zhang wrote:
>     Yeah, I see you added how we set OOM score adjustment in `nested-container-and-task-group.md`
which is specific for nested container, but we also set OOM score adjustment for burstable
command tasks.
> 
> Greg Mann wrote:
>     I added a clarification in the command task section saying that fields in the task
message do the same thing in that case, that seems sufficient to me?

Sounds good to me.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72409/#review220424
-----------------------------------------------------------


On April 29, 2020, 8:01 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72409/
> -----------------------------------------------------------
> 
> (Updated April 29, 2020, 8:01 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
> 
> 
> Bugs: MESOS-10115
>     https://issues.apache.org/jira/browse/MESOS-10115
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds a new document containing an introduction for
> scheduler authors to the available methods for running
> workloads in a Mesos cluster.
> 
> 
> Diffs
> -----
> 
>   docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e 
>   docs/running-workloads.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72409/diff/3/
> 
> 
> Testing
> -------
> 
> Viewed with `site/mesos-website-dev.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message