mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.
Date Thu, 19 Mar 2020 14:40:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72216/#review220008
-----------------------------------------------------------




src/master/validation.cpp
Lines 2015-2017 (patched)
<https://reviews.apache.org/r/72216/#comment308270>

    No need this anymore.



src/master/validation.cpp
Lines 2073-2085 (patched)
<https://reviews.apache.org/r/72216/#comment308271>

    What if the framework launches multiple executors with the same executor ID on multiple
slaves? I think we want to do this validation for the specific slave rather than across slaves.


- Qian Zhang


On March 19, 2020, 9:14 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72216/
> -----------------------------------------------------------
> 
> (Updated March 19, 2020, 9:14 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Qian Zhang.
> 
> 
> Bugs: MESOS-10045
>     https://issues.apache.org/jira/browse/MESOS-10045
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added master validation for task resource limits and shared cgroups.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp 084f281eadd65cb8ae0a19b7b7797dc71ccebdd2 
> 
> 
> Diff: https://reviews.apache.org/r/72216/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message