mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Date Tue, 17 Mar 2020 03:01:32 GMT


> On March 16, 2020, 8:23 p.m., Greg Mann wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp
> > Lines 4624-4628 (patched)
> > <https://reviews.apache.org/r/72211/diff/2/?file=2214054#file2214054line4624>
> >
> >     Are we sure this will hold for all systems? Can we just check that the task
cgroup's limit is infinite?

See my comment here: https://reviews.apache.org/r/72210/#comment308193 . And what do you mean
for `task cgroup's limit`? I do not think we support task group in Docker containerizer.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72211/#review219954
-----------------------------------------------------------


On March 16, 2020, 9:52 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72211/
> -----------------------------------------------------------
> 
> (Updated March 16, 2020, 9:52 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10053
>     https://issues.apache.org/jira/browse/MESOS-10053
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 689a7220a09f2a58dffdf0dc9fd9f0548600be0e

> 
> 
> Diff: https://reviews.apache.org/r/72211/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message