mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 72210: Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
Date Tue, 17 Mar 2020 02:25:51 GMT


> On March 16, 2020, 8:31 p.m., Greg Mann wrote:
> > src/tests/containerizer/cgroups_isolator_tests.cpp
> > Lines 842-845 (patched)
> > <https://reviews.apache.org/r/72210/diff/2/?file=2214048#file2214048line842>
> >
> >     Will this be true on all systems? Can we just check that the task cgroup's memory
limit is -1?

I think it will be true on all systems since root cgroup's limits cannot be modified (you
can search `"we cannot set any limits on the root cgroup"` in https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
). -1 represents infinite limit for CPU CFS quota but not memory limit which uses something
like `9223372036854771712`.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72210/#review219955
-----------------------------------------------------------


On March 16, 2020, 9:51 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72210/
> -----------------------------------------------------------
> 
> (Updated March 16, 2020, 9:51 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp f72e6cdab417368e63349915114aeed586e0ef0e

> 
> 
> Diff: https://reviews.apache.org/r/72210/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message