mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72095: Introduced dedicated `Framework` methods for transitions between states.
Date Fri, 28 Feb 2020 17:37:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72095/
-----------------------------------------------------------

(Updated Feb. 28, 2020, 5:37 p.m.)


Review request for mesos, Benjamin Mahler and Greg Mann.


Changes
-------

Changed `isActive()` back to `active`, addressed other issues.


Bugs: MESOS-10056
    https://issues.apache.org/jira/browse/MESOS-10056


Repository: mesos


Description
-------

The main purpose of this patch is gathering scattered logic of
transitioning `Framework` to disconnected state into
`Framework::disconnect()` method. This is a prerequisite for adding
to the `Framework` state one more entity that needs cleanup when the
framework is disconnected (namely, adding per-framework
`ObjectApprovers` in depending patches).

Additionally, this patch decouples connection state from eligibility
to receive offers: `ACTIVE` and `INACTIVE` states are merged into
`CONNECTED`, and a new boolean attribute `active` is introduced.
Now that `updateConnection(...)` does not change `active` on its own,
methods `activate()` and `deactivate()` are introduced.

Note that the current behaviour of activating reconnected framework
regardless of whether it was active before disconnecting is not changed.

Also, for consistency between `CONNECTED`->`DISCONNECTED` transition
and other state transitions, public `setFrameworkState(...)` method
is removed.


Diffs (updated)
-----

  src/master/framework.cpp a9318a9d33122610960e01a184b568a8ea18b514 
  src/master/master.hpp d774d77a50597770c6f2d4f5dffcbd79b5f29da3 
  src/master/master.cpp 36a81ccd24d0156049382fee0d085193cc2867e6 
  src/master/quota_handler.cpp ea3f85887c96e0a0b14bcb2eb33646032868e0c8 


Diff: https://reviews.apache.org/r/72095/diff/5/

Changes: https://reviews.apache.org/r/72095/diff/4-5/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message