mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 72096: Store per-framework ObjectApprovers.
Date Thu, 27 Feb 2020 22:54:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72096/#review219687
-----------------------------------------------------------


Ship it!





src/master/framework.cpp
Lines 735 (patched)
<https://reviews.apache.org/r/72096/#comment307906>

    not sure we need the "bug:" prefix? most of the check failures are due to bugs?


- Benjamin Mahler


On Feb. 27, 2020, 6:38 p.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72096/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2020, 6:38 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Greg Mann.
> 
> 
> Bugs: MESOS-10056
>     https://issues.apache.org/jira/browse/MESOS-10056
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is a prerequisite to synchronous authorization of scheduler API
> calls (see MESOS-10056).
> 
> 
> Diffs
> -----
> 
>   src/master/framework.cpp a9318a9d33122610960e01a184b568a8ea18b514 
>   src/master/master.hpp d774d77a50597770c6f2d4f5dffcbd79b5f29da3 
>   src/master/master.cpp 36a81ccd24d0156049382fee0d085193cc2867e6 
>   src/tests/master_authorization_tests.cpp bc8155b97c9078eaa151cc4a3e5bc6ea0d7ac9fa 
>   src/tests/master_load_tests.cpp 6bbc1c061684e0c55edde6ab31ef51542d0be980 
> 
> 
> Diff: https://reviews.apache.org/r/72096/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message