mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72099: Removed code for tracking pending tasks.
Date Thu, 27 Feb 2020 18:43:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72099/
-----------------------------------------------------------

(Updated Feb. 27, 2020, 6:43 p.m.)


Review request for mesos, Benjamin Mahler and Greg Mann.


Changes
-------

rebased on top of current master, renumbered reconciliation scenarios in comment


Bugs: MESOS-10056
    https://issues.apache.org/jira/browse/MESOS-10056


Repository: mesos


Description
-------

Now that ACCEPT is authorized synchronously, there are no pending
tasks in-between dispatches on `Master` methods, thus the pending task
tracking code is not needed anymore.


Diffs (updated)
-----

  include/mesos/master/master.proto 8c22802625c80c7fcd64d947b693ab4f5d069142 
  include/mesos/v1/master/master.proto 40de3580681fbb066d8f49c5df8d0c97cd766703 
  src/master/http.cpp 67572a3ffa15b6fbc23d2c2a202023ac9b18cdca 
  src/master/master.hpp d774d77a50597770c6f2d4f5dffcbd79b5f29da3 
  src/master/master.cpp 36a81ccd24d0156049382fee0d085193cc2867e6 
  src/master/readonly_handler.cpp f9c000643d64c9e30849d0d56f329ae052ffd137 
  src/master/validation.hpp b2897132a6bfaa1002663d6aea0fb87246b3d8d8 
  src/master/validation.cpp 2f80536dd3810180385351765965ed6211d372c7 
  src/tests/master_validation_tests.cpp e92ff5913ea43f50b0895d7a2b2dd0efd7361083 


Diff: https://reviews.apache.org/r/72099/diff/4/

Changes: https://reviews.apache.org/r/72099/diff/3-4/


Testing (updated)
-------

make check


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message