mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72095: Introduced dedicated `Framework` methods for transitions between states.
Date Thu, 27 Feb 2020 18:25:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72095/
-----------------------------------------------------------

(Updated Feb. 27, 2020, 6:25 p.m.)


Review request for mesos, Benjamin Mahler and Greg Mann.


Changes
-------

Decoupled RECOVERED/CONNECTED/DISCONNECTED from active/inactive.

Also fixed minor issues.


Bugs: MESOS-10056
    https://issues.apache.org/jira/browse/MESOS-10056


Repository: mesos


Description (updated)
-------

The main purpose of this patch is gathering scattered logic of
transitioning `Framework` to disconnected state into
`Framework::disconnect()` method. This is a prerequisite for adding
to the `Framework` state one more entity that needs cleanup when the
framework is disconnected (namely, adding per-framework
`ObjectApprovers` in depending patches).

Additionally, this patch decouples connection state from eligibility
to receive offers: `ACTIVE` and `INACTIVE` states are merged into
`CONNECTED`, and a new boolean attribute `active` is introduced.
Now that `updateConnection(...)` does not change `active` on its own,
methods `activate()` and `deactivate()` are introduced.

Note that the current behaviour of activating reconnected framework
regardless of whether it was active before disconnecting is not changed.

Also, for consistency between `CONNECTED`->`DISCONNECTED` transition
and other state transitions, public `setFrameworkState(...)` method
is removed.


Diffs (updated)
-----

  src/common/protobuf_utils.cpp 7fe4a44b1e7ded998dffb0490c1d61ced697ebd5 
  src/master/framework.cpp a9318a9d33122610960e01a184b568a8ea18b514 
  src/master/http.cpp 67572a3ffa15b6fbc23d2c2a202023ac9b18cdca 
  src/master/master.hpp d774d77a50597770c6f2d4f5dffcbd79b5f29da3 
  src/master/master.cpp 36a81ccd24d0156049382fee0d085193cc2867e6 
  src/master/quota_handler.cpp ea3f85887c96e0a0b14bcb2eb33646032868e0c8 
  src/master/readonly_handler.cpp f9c000643d64c9e30849d0d56f329ae052ffd137 


Diff: https://reviews.apache.org/r/72095/diff/4/

Changes: https://reviews.apache.org/r/72095/diff/3-4/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message