mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <bbann...@apache.org>
Subject Re: Review Request 72161: Added patch for RapidJSON.
Date Thu, 27 Feb 2020 16:59:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72161/#review219677
-----------------------------------------------------------



Is the plan to upstream this patch? We usually try to enable building against unbundled dependencies
and depending on custom behavior makes that impossible. My hunch would be to not make functional
changes like the one in this patch to dependencies (changes for building are usually fine).

- Benjamin Bannier


On Feb. 25, 2020, 2:07 vorm., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72161/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2020, 2:07 vorm.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10064
>     https://issues.apache.org/jira/browse/MESOS-10064
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit updates the writer of RapidJSON to write infinite
> floating point numbers as "Infinity" and "-Infinity" (i.e.,
> with double quotes) rather than Infinity and -Infinity. This
> is to ensure the strings converted from JSON objects conform
> to the rule defined by Protobuf:
> https://developers.google.com/protocol-buffers/docs/proto3#json
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt c45d742684ba4b3b4abc57ae0bcb85a879c68bfd 
>   3rdparty/rapidjson-1.1.0.patch PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72161/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message