mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 72126: Added a test to ensure agents cannot be reactivated while DRAINING.
Date Tue, 25 Feb 2020 18:46:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72126/#review219660
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/master_draining_tests.cpp
Lines 1109 (patched)
<https://reviews.apache.org/r/72126/#comment307869>

    This agent is reachable right?  It just doesn't have a cooperative executor.


- Joseph Wu


On Feb. 12, 2020, 7:16 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72126/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2020, 7:16 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-10096
>     https://issues.apache.org/jira/browse/MESOS-10096
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test to ensure agents cannot be reactivated while DRAINING.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_draining_tests.cpp f1a00dfdb47b3cc095f7da9c9d3b8fa5933f8846 
> 
> 
> Diff: https://reviews.apache.org/r/72126/diff/1/
> 
> 
> Testing
> -------
> 
> Ran in repetition.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message