mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72066: Improved performance of v1 agent operator API GET_TASKS call.
Date Mon, 24 Feb 2020 19:28:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72066/#review219626
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/http.cpp
Lines 2325-2351 (patched)
<https://reviews.apache.org/r/72066/#comment307833>

    Similarly to r72065 - is it possible to factor this out to make clear that framework/executor
lists in json and protobuf code are composed in indentical way?



src/slave/http.cpp
Lines 2332 (patched)
<https://reviews.apache.org/r/72066/#comment307838>

    newline?



src/slave/http.cpp
Lines 2379 (patched)
<https://reviews.apache.org/r/72066/#comment307834>

    Given that our styleguide builds on top of Google's C++ styleguide, shouldn't `using`
be preferred over `typedef` for type aliases?



src/slave/http.cpp
Lines 2428 (patched)
<https://reviews.apache.org/r/72066/#comment307835>

    `const Task*` here and below?



src/slave/http.cpp
Lines 2445-2446 (patched)
<https://reviews.apache.org/r/72066/#comment307836>

    CHECK_NOTNULL when calling `approved()`?



src/slave/http.cpp
Lines 2461 (patched)
<https://reviews.apache.org/r/72066/#comment307837>

    Technically, shared_ptr can also store nullptr -  why have CHECK_NOTNULL in the loop before
and don't have it here?


- Andrei Sekretenko


On Jan. 30, 2020, 9:31 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72066/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2020, 9:31 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Greg Mann.
> 
> 
> Bugs: MESOS-10026
>     https://issues.apache.org/jira/browse/MESOS-10026
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This follow the same approach used for the master's v1 calls:
> 
> https://github.com/apache/mesos/commit/d7dd4d0e8493331d7b7a21b504eb
> https://github.com/apache/mesos/commit/3dda3622f5ed01e8c132dc5ca594
> 
> That is, serializing directly to protobuf or json from the in-memory
> v0 state.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.hpp 0afdad9479f0cc2c94452b6b1f2289dd6ea01494 
>   src/slave/http.cpp 04ad0d816618a1880913857a6f0ff38c4643c488 
> 
> 
> Diff: https://reviews.apache.org/r/72066/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message