mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 72157: Removed reimplementation of `cloexec` from systemd activation code.
Date Mon, 24 Feb 2020 14:35:01 GMT


> On Фев. 24, 2020, 1:10 п.п., Andrei Sekretenko wrote:
> > src/linux/systemd.cpp
> > Line 352 (original)
> > <https://reviews.apache.org/r/72157/diff/2/?file=2211997#file2211997line354>
> >
> >     `cloexec(...)` from stout doesn't have this optimization and always calls `fcntl(fd,
F_SETFD, ...)`; makes me wonder if we would want to port it there now or later...

I think this optimisation is not necessary here. If it is found that this optimisation is
important, we can add it later.


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72157/#review219635
-----------------------------------------------------------


On Фев. 21, 2020, 12:30 п.п., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72157/
> -----------------------------------------------------------
> 
> (Updated Фев. 21, 2020, 12:30 п.п.)
> 
> 
> Review request for mesos, Andrei Sekretenko, Greg Mann, and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed reimplementation of `cloexec` from systemd activation code.
> 
> 
> Diffs
> -----
> 
>   src/linux/systemd.cpp 9897473115ac0f9809734c109ba412eefd32e59e 
> 
> 
> Diff: https://reviews.apache.org/r/72157/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message