mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72098: Converted ACCEPT to synchronous authorization.
Date Thu, 13 Feb 2020 16:42:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72098/
-----------------------------------------------------------

(Updated Feb. 13, 2020, 4:42 p.m.)


Review request for mesos, Benjamin Mahler and Greg Mann.


Changes
-------

Dropped use of `boost::transform_iterator`: build with bundled `boost` fails (due to `transform_iterator`
not bundled), and rebundling doesn't look worth it.


Bugs: MESOS-10023, MESOS-10056 and MESOS-10083
    https://issues.apache.org/jira/browse/MESOS-10023
    https://issues.apache.org/jira/browse/MESOS-10056
    https://issues.apache.org/jira/browse/MESOS-10083


Repository: mesos


Description
-------

This patch converts ACCEPT call to synchronous authorization
(see MESOS-10056), thus fixing race between ACCEPT and REVIVE
(MESOS-10023) and removing potential for other similar races.

It also moves authorization of scheduler API operations after their
validation (thus fixing MESOS-10083) and effectively gets rid of the
concept of a "task pending authorization".

Tests are converted from mocking `Authorizer::authorized(...)`
to mocking `Authorizer::provideObjectApprover(...)` as necessary.


Diffs (updated)
-----

  src/master/authorization.cpp 77719eb079b2a19e0841573f639437aa3bb0fe54 
  src/master/framework.cpp e69a7c26d15ffffb3d147328032f996962387c96 
  src/master/master.hpp c813e9fc855cfb1701ec32be7f690e06b6eb203f 
  src/master/master.cpp d41ae724ba12b5ad1c8ae3c1f9b91a05b0e46e7e 
  src/tests/master_authorization_tests.cpp bc8155b97c9078eaa151cc4a3e5bc6ea0d7ac9fa 
  src/tests/master_tests.cpp 9688f5f0266f7c7142b54d488f2c13b427e542c0 
  src/tests/reconciliation_tests.cpp cdff370c5871ded0cb10b8b782bd669e092eb741 


Diff: https://reviews.apache.org/r/72098/diff/3/

Changes: https://reviews.apache.org/r/72098/diff/2-3/


Testing
-------


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message