mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Sekretenko <asekrete...@mesosphere.io>
Subject Re: Review Request 72094: Made `http`, `pid` and `heartbeater` of `Framework` private.
Date Thu, 13 Feb 2020 12:38:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72094/
-----------------------------------------------------------

(Updated Feb. 13, 2020, 12:38 p.m.)


Review request for mesos, Benjamin Mahler and Greg Mann.


Changes
-------

Moved replacing `http->close()` with `closeHttpConnection()` into https://reviews.apache.org/r/72130/


Bugs: MESOS-10056
    https://issues.apache.org/jira/browse/MESOS-10056


Repository: mesos


Description
-------

This is a prerequisite to localizing mutations of connection-related
state of `Framework` to a limited set of `Framework` methods
in the next patch.


Diffs (updated)
-----

  src/master/framework.cpp e69a7c26d15ffffb3d147328032f996962387c96 
  src/master/http.cpp eeaac88c893b43170e655f8bff1d57dd0f7bbfb2 
  src/master/master.hpp c813e9fc855cfb1701ec32be7f690e06b6eb203f 
  src/master/master.cpp d41ae724ba12b5ad1c8ae3c1f9b91a05b0e46e7e 
  src/master/readonly_handler.cpp 40005a2ac2cc9dd6075425c184d220f0a2fbee99 


Diff: https://reviews.apache.org/r/72094/diff/3/

Changes: https://reviews.apache.org/r/72094/diff/2-3/


Testing
-------

make check


Thanks,

Andrei Sekretenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message