mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 72125: Disallow reactivating a DRAINING agent.
Date Thu, 13 Feb 2020 03:15:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72125/
-----------------------------------------------------------

Review request for mesos, Greg Mann and Joseph Wu.


Bugs: MESOS-10096
    https://issues.apache.org/jira/browse/MESOS-10096


Repository: mesos


Description
-------

When reactivating an agent that's in the draining state, the master
erases it from its draining maps, and erases its estimated drain time.
However, it doesn't send any message to the agent, so if the agent is
still draining and waiting for tasks to terminate, it will stay in
that state, ultimately making any tasks that then get launched get
DROPPED due to the agent still being in a draining state.

To avoid this confusing scenario, we disallow reactivating a DRAINING
agent, since that seems to have been the original design intent.


Diffs
-----

  src/master/http.cpp eeaac88c893b43170e655f8bff1d57dd0f7bbfb2 


Diff: https://reviews.apache.org/r/72125/diff/1/


Testing
-------

Added a test in the subsequent patch.


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message